Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated processes #35

Merged
merged 1 commit into from
Mar 1, 2022
Merged

Remove outdated processes #35

merged 1 commit into from
Mar 1, 2022

Conversation

m-mohr
Copy link
Member

@m-mohr m-mohr commented Feb 28, 2022

These are very much outdated (pre-1.0.0) and it seems we should simply remove them to not get into trouble with people using them (already happened). I think the pg parser should be very much independent of any process release/version and instead, people should always provide their own definitions instead.

Would be nice to get tests running before, but I can't get them running right now (due to lack of Python knowledge, I assume). #36

@m-mohr m-mohr linked an issue Feb 28, 2022 that may be closed by this pull request
@clausmichele
Copy link
Member

@m-mohr would it be possible to expose all the available openEO processes listed on https://processes.openeo.org/ as a JSON as the back-ends are doing in the /processes endpoint? If yes, we could let the parser point to this official list of processes as default and this would solve the tests issue.

@m-mohr
Copy link
Member Author

m-mohr commented Mar 1, 2022

Yes, you can use https://processes.openeo.org/processes.json (for latest) and https://processes.openeo.org/{version}/processes.json (for a tagged version) as baseline. The tests could point to this, indeed, but there shouldn't be a default, I think.
Actually, no specific version should be bundled with the PG parser as PG parsing should be agnostic of the versions of the processes. So each implementation should pass the actual list of processes so that the validation actually validates against the actual implementation, not against the openEO-wide specification.

@clausmichele
Copy link
Member

Totally agree. I think we can merge this and I will try to fix the tests in another PR.

@m-mohr m-mohr merged commit ae32f43 into master Mar 1, 2022
@m-mohr m-mohr deleted the update-processes branch March 1, 2022 13:50
@m-mohr
Copy link
Member Author

m-mohr commented Mar 1, 2022

Merged. I would appreciate if you could work on the tests, @clausmichele.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Process definitions outdated
3 participants