Date replace and Date get #433

PondiB · 2023-04-15T14:01:39Z

Implementation for issue #254
closes #254

proposals/date_get.json

proposals/date_replace.json

proposals/date_get.json

proposals/date_replace.json

Open-EO/openeo-processes#433 #205

proposals/date_get_component.json

proposals/date_replace_component.json

m-mohr

Not a big fan of the _component suffix, otherwise just added a couple of minor comments to clean-up the descriptions. Overall very solid proposals, I think.

Has this been tested against common date-time libraries, especially the ones that are mentioned in the implementation guide? It would be good to know whether all the edge cases have been found, documented and been tested with at least the 4 libraries mentioned there (this is the reason for the change request).

Co-authored-by: Matthias Mohr <[email protected]>

PondiB · 2023-10-03T06:25:35Z

Not a big fan of the _component suffix, otherwise just added a couple of minor comments to clean-up the descriptions. Overall very solid proposals, I think.

Okay

Has this been tested against common date-time libraries, especially the ones that are mentioned in the implementation guide? It would be good to know whether all the edge cases have been found, documented and been tested with at least the 4 libraries mentioned there (this is the reason for the change request).

Not really. What implementation guide?

m-mohr · 2023-10-03T11:14:47Z

What implementation guide?

https://github.com/Open-EO/openeo-processes/blob/master/meta/implementation.md

soxofaan · 2023-10-03T14:00:56Z

Not a big fan of the _component suffix,

You're not a fan of _component as a suffix, or any suffix at all? Do you have other suggestions?

m-mohr · 2023-10-03T14:03:45Z

You're not a fan of _component as a suffix, or any suffix at all? Do you have other suggestions?

date_get and date_replace seem fine to me, but I'm not the dictator so if many prefer the _component suffix, I'm fine with it. I don't have a good alternative at hand (maybe "part"), I also don't think we hve anything comparable right now, which we can borrow from.

soxofaan · 2023-10-03T14:31:19Z

the closest comparable process is array_element I think, so date_element could make sense too

PondiB · 2023-11-07T16:23:34Z

date_replace_component and date_get_component is more intuitive to me than date_replace, date_get and date_element.

PondiB · 2023-12-08T13:37:27Z

@m-mohr , if there is no further review of this then kindly approve.

PondiB · 2023-12-08T13:55:27Z

@soxofaan 👆🏾

soxofaan

no further remarks from me, we already iterated enough on this on I guess :)

PondiB · 2023-12-08T14:05:05Z

no further remarks from me, we already iterated enough on this on I guess :)

Sure, thanks.

it's solid now.

m-mohr · 2023-12-08T14:15:47Z

@PondiB You did never followed-up on the comment with regards to extending the implementation guide. Any updates on that?

proposals/date_get_component.json

m-mohr · 2023-12-08T14:19:31Z

proposals/date_get_component.json

+                    "minute",
+                    "hour",
+                    "day",
+                    "day of week",


Is day of week Monday or Sunday based? Does it start with 0 or 1? Does it return numbers or strings?

m-mohr · 2023-12-08T14:20:04Z

proposals/date_get_component.json

+                    "day of week",
+                    "day of year",
+                    "week",
+                    "week number",


zero or one based? What's the difference between week and week number?

m-mohr · 2023-12-08T14:21:50Z

proposals/date_get_component.json

+        },
+        {
+            "name": "component",
+            "description": "The component for the value given. The following pre-defined components are available:\n\n- millisecond: Milliseconds\n- second: Seconds .\n- minute: Minutes\n- hour: Hours\n- day: Days - changes only the the day part of a date\n- day of week: Day of Week\n- day of year: Day of Year\n- week: Weeks (equivalent to 7 days)\n- week number: Week Number\n- month: Months\n- year: Years\n\nReplacements with the component `year`, `month` or `day` do never change the time.",


The description needs to be made much more precise with regards to value ranges for example. See comments below.

m-mohr

Did a quick review. See comments above. Also, the implementation guide on what libraries support exactly this should be added (compare to the other date processes).

PondiB · 2023-12-12T09:32:16Z

Did a quick review. See comments above. Also, the implementation guide on what libraries support exactly this should be added (compare to the other date processes).

Cool, thanks. I'll address them later.

PondiB added 6 commits April 11, 2023 21:41

initialization

0782ad9

date_replace base implementation

d12d479

Update date_replace descriptions

1aaaae1

date_get implelementation

b7f125f

date_get fix naming issue

a05985b

date_get description update

72a639f

PondiB requested review from soxofaan and m-mohr April 15, 2023 14:01

m-mohr added this to the 2.1.0 milestone Apr 15, 2023

m-mohr added the new process label Apr 15, 2023

soxofaan reviewed Apr 17, 2023

View reviewed changes

PondiB added 5 commits April 17, 2023 15:08

update date_replace and date_get_component based on feedbacks

c8b4691

Update descriptions

cd51493

reduce white space

57427cc

update descriptions and example for date/time overflows

4a7ed9d

correct wordings'

fab0d95

PondiB mentioned this pull request Sep 21, 2023

Date replace and/or get processes #254

Open

soxofaan reviewed Sep 22, 2023

View reviewed changes

proposals/date_replace.json Outdated Show resolved Hide resolved

proposals/date_replace.json Outdated Show resolved Hide resolved

refactored

5d5a50f

jdries added a commit to Open-EO/openeo-geotrellis-extensions that referenced this pull request Sep 25, 2023

add date_replace_component

39f1521

Open-EO/openeo-processes#433 #205

jdries added a commit to Open-EO/openeo-geotrellis-extensions that referenced this pull request Sep 25, 2023

add date_replace_component

c983a06

Open-EO/openeo-processes#433 #205

jdries added a commit to Open-EO/openeo-geotrellis-extensions that referenced this pull request Sep 27, 2023

date_difference: improve spec compliancy

1450d32

Open-EO/openeo-processes#433 #205

m-mohr reviewed Sep 30, 2023

View reviewed changes

proposals/date_get_component.json Outdated Show resolved Hide resolved

m-mohr reviewed Sep 30, 2023

View reviewed changes

proposals/date_get_component.json Outdated Show resolved Hide resolved

m-mohr reviewed Sep 30, 2023

View reviewed changes

proposals/date_replace_component.json Outdated Show resolved Hide resolved

m-mohr previously requested changes Sep 30, 2023

View reviewed changes

PondiB and others added 3 commits October 3, 2023 08:16

Update proposals/date_get_component.json

5391a6a

Co-authored-by: Matthias Mohr <[email protected]>

Update proposals/date_replace_component.json

e2a2793

Co-authored-by: Matthias Mohr <[email protected]>

Update proposals/date_get_component.json

9743439

Co-authored-by: Matthias Mohr <[email protected]>

soxofaan approved these changes Dec 8, 2023

View reviewed changes

PondiB closed this Dec 8, 2023

PondiB reopened this Dec 8, 2023

Open-EO deleted a comment from PondiB Dec 8, 2023

m-mohr reviewed Dec 8, 2023

View reviewed changes

proposals/date_get_component.json Outdated Show resolved Hide resolved

m-mohr reviewed Dec 8, 2023

View reviewed changes

m-mohr requested changes Dec 8, 2023

View reviewed changes

refactor

770962a

Open-EO deleted a comment from PondiB Jan 3, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Date replace and Date get #433

Date replace and Date get #433

PondiB commented Apr 15, 2023

m-mohr left a comment •

edited

Loading

PondiB commented Oct 3, 2023

m-mohr commented Oct 3, 2023

soxofaan commented Oct 3, 2023

m-mohr commented Oct 3, 2023

soxofaan commented Oct 3, 2023

PondiB commented Nov 7, 2023

PondiB commented Dec 8, 2023

PondiB commented Dec 8, 2023

soxofaan left a comment

PondiB commented Dec 8, 2023

m-mohr commented Dec 8, 2023 •

edited

Loading

m-mohr Dec 8, 2023 •

edited

Loading

m-mohr Dec 8, 2023 •

edited

Loading

m-mohr Dec 8, 2023

m-mohr left a comment •

edited

Loading

PondiB commented Dec 12, 2023

Date replace and Date get #433

Are you sure you want to change the base?

Date replace and Date get #433

Conversation

PondiB commented Apr 15, 2023

m-mohr left a comment • edited Loading

Choose a reason for hiding this comment

PondiB commented Oct 3, 2023

m-mohr commented Oct 3, 2023

soxofaan commented Oct 3, 2023

m-mohr commented Oct 3, 2023

soxofaan commented Oct 3, 2023

PondiB commented Nov 7, 2023

PondiB commented Dec 8, 2023

PondiB commented Dec 8, 2023

soxofaan left a comment

Choose a reason for hiding this comment

PondiB commented Dec 8, 2023

m-mohr commented Dec 8, 2023 • edited Loading

m-mohr Dec 8, 2023 • edited Loading

Choose a reason for hiding this comment

m-mohr Dec 8, 2023 • edited Loading

Choose a reason for hiding this comment

m-mohr Dec 8, 2023

Choose a reason for hiding this comment

m-mohr left a comment • edited Loading

Choose a reason for hiding this comment

PondiB commented Dec 12, 2023

m-mohr left a comment •

edited

Loading

m-mohr commented Dec 8, 2023 •

edited

Loading

m-mohr Dec 8, 2023 •

edited

Loading

m-mohr Dec 8, 2023 •

edited

Loading

m-mohr left a comment •

edited

Loading