Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue #678 support shapely in load collection spatial extent #682

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

issue #678 support shapely in load collection spatial extent #682

wants to merge 7 commits into from
+145 −82

Conversation

ElienVandermaesenVITO
Copy link

issue #678

soxofaan
soxofaan reviewed Dec 12, 2024
View reviewed changes
Copy link
Member

@soxofaan soxofaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the delay

already looks great.

openeo/rest/datacube.py Outdated Show resolved Hide resolved
openeo/rest/datacube.py Show resolved Hide resolved
tests/rest/datacube/test_datacube.py Show resolved Hide resolved
@soxofaan
Copy link
Member

Also to be added is a bullet in changelog (under "Added" section)

soxofaan
soxofaan reviewed Dec 13, 2024
View reviewed changes
Copy link
Member

@soxofaan soxofaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some additional notes

CHANGELOG.md Outdated Show resolved Hide resolved
openeo/rest/connection.py Show resolved Hide resolved
openeo/rest/datacube.py Outdated Show resolved Hide resolved
soxofaan
soxofaan reviewed Dec 18, 2024
View reviewed changes
Copy link
Member

@soxofaan soxofaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some more notes :)

openeo/rest/connection.py Outdated Show resolved Hide resolved
openeo/rest/datacube.py Outdated Show resolved Hide resolved
openeo/rest/datacube.py Show resolved Hide resolved
openeo/rest/datacube.py Show resolved Hide resolved
openeo/rest/datacube.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soxofaan soxofaan Awaiting requested review from soxofaan

Assignees

@ElienVandermaesenVITO ElienVandermaesenVITO

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ElienVandermaesenVITO @soxofaan