Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor bugs with the flashlight application 🔦 #370

Merged
merged 4 commits into from
Sep 24, 2023
Merged

Minor bugs with the flashlight application 🔦 #370

merged 4 commits into from
Sep 24, 2023

Conversation

simonmicro
Copy link
Member

@simonmicro simonmicro commented Sep 23, 2023 •
edited
Loading

  • Constant brightness application anymore (spams logs)
  • Display turned off, while active
  • Do not allow state manipulation without activity

@simonmicro simonmicro added 🐞 bug Something isn't working src/osw-app This PR / issue impacts the current release of the OS labels Sep 23, 2023
@simonmicro simonmicro self-assigned this Sep 23, 2023
@simonmicro
Copy link
Member Author

Args. This also hinges on a fix introduced with #368 (RTCDateTime removed some deprecated stuff)... Hmpf

@simonmicro simonmicro marked this pull request as draft September 23, 2023 14:34
@simonmicro simonmicro marked this pull request as ready for review September 23, 2023 15:00
@simonmicro simonmicro merged commit 2cddafd into develop Sep 24, 2023
79 checks passed
@simonmicro simonmicro deleted the bugs/flashlight branch September 24, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RuffaloLavoisier RuffaloLavoisier RuffaloLavoisier approved these changes

Assignees

@simonmicro simonmicro

Labels
🐞 bug Something isn't working src/osw-app This PR / issue impacts the current release of the OS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simonmicro @RuffaloLavoisier