Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Anti aliasing / Analog-Fitness Watchface / Cleanups #380

Merged
merged 22 commits into from
May 20, 2024
Merged

Anti aliasing / Analog-Fitness Watchface / Cleanups #380

merged 22 commits into from
May 20, 2024

Conversation

zwim
Copy link
Contributor

@zwim zwim commented Mar 24, 2024 •
edited
Loading

This PR will allow the use of anti-aliased lines :)

grafik

Should work now as expected, draft as I want to clean up a bit.

@zwim zwim marked this pull request as ready for review March 26, 2024 10:41
simonmicro
simonmicro requested changes Apr 6, 2024
View reviewed changes
Copy link
Member

@simonmicro simonmicro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi!

Thanks for your work! Next time...

  • split up your contributions into smaller pull requests - this is a chonker (slow to review, slower to discuss/fix/merge)!
  • please update the description of your PR, so the MR later on reflects what have been done

lib/Arduino_GFX Outdated Show resolved Hide resolved
src/apps/watchfaces/OswAppWatchfaceFitnessAnalog.cpp Outdated Show resolved Hide resolved
src/apps/watchfaces/OswAppWatchfaceFitnessAnalog.cpp Outdated Show resolved Hide resolved
src/apps/watchfaces/OswAppWatchfaceFitnessAnalog.cpp Outdated Show resolved Hide resolved
src/apps/watchfaces/OswAppWatchfaceFitnessAnalog.cpp Outdated Show resolved Hide resolved
src/hal/power.cpp Outdated Show resolved Hide resolved
src/hal/power.cpp Outdated Show resolved Hide resolved
src/math_tables.cpp Show resolved Hide resolved
src/osw_config_keys.cpp Show resolved Hide resolved
src/osw_hal.cpp Outdated Show resolved Hide resolved
@simonmicro
Copy link
Member

Also, I fear your newly added watchface is not happy with the GIF-background enabled. Could you also fix this?

@zwim
Copy link
Contributor Author

zwim commented Apr 8, 2024

Typos fixed.

simonmicro
simonmicro reviewed Apr 13, 2024
View reviewed changes
platformio.ini Outdated Show resolved Hide resolved
src/gfx_util.cpp Outdated Show resolved Hide resolved
src/osw_hal.cpp Show resolved Hide resolved
@simonmicro simonmicro marked this pull request as draft April 13, 2024 08:17
@simonmicro
Copy link
Member

Moved it back to draft state, as there are still a lot of (minor) stuff

@simonmicro simonmicro changed the base branch from master to develop April 13, 2024 08:29
@simonmicro
Copy link
Member

I am very sorry for not taking a look at this again, but as it was marked as draft I did not think that there was any progress.

@simonmicro
Copy link
Member

I'll go ahead and rebase you on top the current develop to get the CI working again.

simonmicro
simonmicro approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@simonmicro simonmicro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simonmicro simonmicro marked this pull request as ready for review May 20, 2024 13:10
@simonmicro simonmicro marked this pull request as draft May 20, 2024 13:11
@simonmicro
Copy link
Member

@zwim if you think you are ready, please promote this PR from draft to "ready-to-review"

@simonmicro simonmicro added ⭐ enhancement New feature or request src/osw-app This PR / issue impacts the current release of the OS src/core src/osw-watchface labels May 20, 2024
@zwim
Copy link
Contributor Author

zwim commented May 20, 2024

I am very sorry for not taking a look at this again, but as it was marked as draft I did not think that there was any progress.

No problem.

@zwim zwim marked this pull request as ready for review May 20, 2024 18:30
zwim and others added 20 commits May 20, 2024 21:30
@simonmicro simonmicro added the ✔️ merge when CI passed Note for the maintainers: Merge the PR ASAP after the CI finished label May 20, 2024
@simonmicro simonmicro changed the title Anti aliasing Anti aliasing / Analog-Fitness Watchface / Cleanups May 20, 2024
@simonmicro simonmicro merged commit 2b56c3d into Open-Smartwatch:develop May 20, 2024
127 checks passed
@zwim zwim deleted the anti-aliasing branch May 21, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonmicro simonmicro simonmicro approved these changes

Assignees

@zwim zwim

Labels
✔️ merge when CI passed Note for the maintainers: Merge the PR ASAP after the CI finished src/core src/osw-app This PR / issue impacts the current release of the OS src/osw-watchface ⭐ enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zwim @simonmicro