Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resize Time/Date date type #401

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Resize Time/Date date type #401

wants to merge 1 commit into from

Conversation

RuffaloLavoisier
Copy link
Member

Hi there ✋

PR description.

  • day max value is 31 (need to 8 bit) and month max value is 12 (need to 4 bit), and weekday is 7.. so need to 4 bit.

@RuffaloLavoisier RuffaloLavoisier marked this pull request as draft September 16, 2024 07:54
@RuffaloLavoisier
Copy link
Member Author

@simonmicro
There are many over-declared data types than the data max-value range. What do you think about this?

simonmicro
simonmicro requested changes Sep 22, 2024
View reviewed changes
Copy link
Member

@simonmicro simonmicro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good idea - but you may need to fix a lot of stuff

@RuffaloLavoisier RuffaloLavoisier marked this pull request as ready for review September 25, 2024 14:51
@RuffaloLavoisier RuffaloLavoisier force-pushed the checkDateParam branch 3 times, most recently from d4c1db6 to d2939cb Compare September 28, 2024 11:28
@RuffaloLavoisier RuffaloLavoisier marked this pull request as draft October 20, 2024 20:59
@RuffaloLavoisier RuffaloLavoisier changed the title Resize param data type Resize Time/Date date type Oct 23, 2024
@RuffaloLavoisier RuffaloLavoisier marked this pull request as ready for review November 21, 2024 15:12
@RuffaloLavoisier
Copy link
Member Author

Why don't we revise the rest of the parts later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonmicro simonmicro Awaiting requested review from simonmicro

Assignees

@RuffaloLavoisier RuffaloLavoisier

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RuffaloLavoisier @simonmicro