Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

187: schema rule for geojson conversion compatability #283

Open
wants to merge 5 commits into
base: 0.3-dev
Choose a base branch
from

Conversation

odscjen
Copy link
Collaborator

@odscjen odscjen commented May 23, 2024

Related issues

closes #187

Description

Merge checklist

  • Update the changelog (style guide)
  • Run ./manage.py pre-commit to update derivative schema files, reference documentation and examples

If there are changes to network-schema.json, network-package-schema.json, reference/publication_formats/json.md, reference/publication_formats/geojson.md or guidance/publication.md#how-to-publish-large-networks, update the relevant manually authored examples:

  • examples/json/:
    • network-package.json
    • api-response.json
    • multiple-networks.json
    • network-embedded.json
    • network-separate-endpoints.json
    • network-separate-files.json
    • nodes-endpoint.json
    • spans-endpoint.json
  • examples/geojson/:
    • api-response.geojson
    • multiple-networks.geojson

If you used a validation keyword, type or format that is not already used in the schema:

If you added a normative rule that is not encoded in JSON Schema:

If there are changes to examples/geojson/nodes.geojson or examples/geojson/spans.geojson, check and update the data use examples:

  • examples/leaflet/leaflet.ipynb
  • examples/qgis/geojson.qgs

@odscjen odscjen marked this pull request as ready for review May 23, 2024 15:22
@odscjen odscjen requested a review from duncandewhurst May 23, 2024 15:22
@odscjen
Copy link
Collaborator Author

odscjen commented May 23, 2024

linkcheck error is the same as the for my other PRs.

I don't understand the Precommit error? I also don't understand why manage.py updated 2 of the csv examples when all I'd done was add some validation rule to the json schema

@odscjen
Copy link
Collaborator Author

odscjen commented May 28, 2024

created issue about pre-commit errors #285

@odscjen
Copy link
Collaborator Author

odscjen commented May 28, 2024

#284 to fix linkcheck error, once that's merged into main, rebase this branch/merge main into this branch

@odscjen
Copy link
Collaborator Author

odscjen commented Jun 19, 2024

see #285 for fix for pre-commit errors

@odscjen
Copy link
Collaborator Author

odscjen commented Jun 20, 2024

@duncandewhurst all errors now fixed, this is properly ready for a review now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Schema: Add rules to ensure data is suitable for conversion to GeoJSON
1 participant