Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remoteproc: implement rproc_virtio_read_config/rproc_virtio_write_config #171

Closed
wants to merge 1 commit into from
Closed

remoteproc: implement rproc_virtio_read_config/rproc_virtio_write_config #171

wants to merge 1 commit into from

Conversation

xiaoxiang781216
Copy link
Collaborator

so the rpmsg could access the configuration space as needed

Signed-off-by: Xiang Xiao [email protected]

@xiaoxiang781216
Copy link
Collaborator Author

xiaoxiang781216 commented Mar 29, 2019 •
edited
Loading

@wjliang , this patch split from #155 since it be commited first independently without the collaboration with kernel community

@wjliang
Copy link
Collaborator

wjliang commented Apr 5, 2019

Looks good to me, with small fix required.

wjliang
wjliang approved these changes May 25, 2019
View reviewed changes
lib/remoteproc/remoteproc_virtio.c Outdated Show resolved Hide resolved
@xiaoxiang781216
Copy link
Collaborator Author

@arnopo please review the updated patch which address @wjliang 's concern.

@xiaoxiang781216
Copy link
Collaborator Author

xiaoxiang781216 commented Apr 23, 2020 •
edited
Loading

@arnopo could your guy spend some time to fix the build break?
image
The code quality seem to bad for me. Is any people inside Linaro org take care the build break?

@arnopo
Copy link
Collaborator

arnopo commented Apr 23, 2020 •
edited
Loading

@arnopo could your guy spend some time to fix the build break?
image
The code quality seem to bad for me. Is any people inside Linaro org take care the build break?

Please test with this PR sent yesterday OpenAMP/libmetal#115

@arnopo arnopo requested review from arnopo and edmooring April 23, 2020 14:50
@arnopo
Copy link
Collaborator

arnopo commented Apr 23, 2020

@arnopo could your guy spend some time to fix the build break?
image
The code quality seem to bad for me. Is any people inside Linaro org take care the build break?

Please test with this PR sent yesterday OpenAMP/libmetal#115

ok forget my comment, i integrated the fix in libmetal, now test is ok

@xiaoxiang781216
Copy link
Collaborator Author

@arnopo , thanks for fast response. The test is pass now, feel free to givre your feedback.

@arnopo
Copy link
Collaborator

arnopo commented Apr 23, 2020

@arnopo , thanks for fast response. The test is pass now, feel free to givre your feedback.

We are now in release process for the v2020.04. I plan to review your patches after that

@xiaoxiang781216
Copy link
Collaborator Author

@arnopo , thanks for fast response. The test is pass now, feel free to givre your feedback.

We are now in release process for the v2020.04. I plan to review your patches after that

Sure.

@xiaoxiang781216
remoteproc: implement rproc_virtio_read_config/rproc_virtio_write_config
0c00641 
so the rpmsg could access the configuration space as needed

Signed-off-by: Xiang Xiao <[email protected]>
@xiaoxiang781216 xiaoxiang781216 changed the title implement rproc_virtio_read_config/rproc_virtio_write_config remoteproc: implement rproc_virtio_read_config/rproc_virtio_write_config Apr 23, 2020
@xiaoxiang781216
Copy link
Collaborator Author

Move to #155

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjliang wjliang wjliang approved these changes

@arnopo arnopo Awaiting requested review from arnopo

@edmooring edmooring Awaiting requested review from edmooring

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xiaoxiang781216 @wjliang @arnopo