rpmsg/rpmsg_virtio: support set trace callback to trace buffer status #632
Conversation
| @@ -139,5 +139,10 @@ if (DEFINED RPMSG_BUFFER_SIZE) | |||
| endif (DEFINED RPMSG_BUFFER_SIZE) | |||
|
|
|||
| option (WITH_DOC "Build with documentation" OFF) | |||
| option (WITH_RPMSG_TRACE "Enable Rpmsg Device Trace" OFF) | |||
|
|
|||
| if (WITH_RPMSG_TRACE) | |||
There was a problem hiding this comment.
Please explain commit mesasge in detail what this option is for.
There was a problem hiding this comment.
Adding this is to track the application and release of rpmsg buffer,then connect to the OS trace system
There was a problem hiding this comment.
Have you checked virtqueue_dump functionality? Is it not enough for above purpose?
There was a problem hiding this comment.
Virtqueue_dump is not enough for record historical information of buffer application and release.
it just record the info of virtqueue
There was a problem hiding this comment.
Look to me too complex just for some specific traces...
What about using RPMSG_DEBUG in open-amp/lib/rpmsg/rpmsg_internal.h?
Then you could define RPMSG_LOG macro to add debug traces in RPMSG
| * @release_tx_buffer: trace callback, called when release a tx buffer | ||
| */ | ||
| struct rpmsg_device_trace { | ||
| void (*get_tx_buffer)(struct rpmsg_device *rvdev, void *hdr); |
There was a problem hiding this comment.
What these callbacks are expected to trace ?
There was a problem hiding this comment.
rpmsg_get_tx_payload_buffer and rpmsg_release_tx_buffer
Adding this is to track the application and release of rpmsg buffer, then connect to the OS trace system Signed-off-by: Bowen Wang <[email protected]>
luckyyaojin
force-pushed
the
trace-debug-amp
branch
from
123fdb6 to
2d948b9
Compare
|
@arnopo hi, please help me to solve this ci problem, think you very much: open-amp Heath Check / Zephyr build from latest on main (pull_request) CMake Error at /github/workspace/zephyrproject/zephyr/cmake/modules/boards.cmake:228 (message): -- Configuring incomplete, errors occurred! |
I will have a look , you can ignore it for the moment , only the required checks are mandatory |
support set trace callback to trace buffer status
Adding this is to track the application and release of rpmsg buffer,then connect to the OS trace system
users can enable RPMSG_TRACE to monitor application and release of txbuffer