-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to sbt-dynver for versioning. #25
Conversation
|
||
jobs: | ||
build: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v2 | ||
with: | ||
fetch-depth: 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should cause github to fetch tags during checkout.
The only improvement I can think to offer here would be for @jimschubert to create a separate bintray repository for snapshots so that the latest version in the release repo is always a tagged release. But that's definitely not necessary. |
Looks like this relates to #2. This could be a stop gap until full cross-repo automation is setup 🤷 open to input on direction. |
Bump @jimschubert not sure if you've had a chance to see this, know your notifications are hosed on this repo. Let me know what you think. |
@jrouly oddly, I got the notification for your ping today... I think this looks fine. I can go ahead and merge if there are no concerns. We definitely need to work out release vs snapshot. I've just had a lot of stuff going on in my personal life and not really any time for open source the last few months. |
@jimschubert absolutely no problem. Just figured I'd check in after the holidays in case you hadn't seen it, but no pressure. If you're able, I'd say go ahead and merge - just make sure to tag master as |
Cool. I tagged current master. Let's see how this new approach works. |
Oh shoot @jimschubert you dropped the Try creating a new tag+release ( That should trigger a new build and produce a new snapshot for the latest commit (db312d3). |
Looks like that worked, thanks a bunch for bearing with me through this. I'm excited to see |
Switch to using
sbt-dynver
for versioning.Merged pull requests will publish snapshots automatically - for example, if you tag
master
atv5.0.0-beta2
before merging this, the next published version after merging would be something like5.0.0-beta2+1-f7c1a0cb
.I also added a
release
trigger for thesbt
github action, which will publish versioned artifacts whenever you create a new tag onmaster
. So, the workflow for releasing new versions would simply be updating the dependency version, merging, and creating a github release.I tested this out on my fork and it seems to work.
5.0.0-beta3
published to Bintray as5.0.0-beta2+8-44a96724
.v5.0.0-beta3
published to Bintray as5.0.0-beta3
.Per the dynver docs, you can replace the
+
with a-
in snapshot version strings or force-SNAPSHOT
for Sonatype compatibility, if either of those are interesting to you. Not sure what your plans for this repo are. Alternatively you can totally customize the version strings.@jimschubert