-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature reduce #175
Feature reduce #175
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I think it is good that we assume the perturbable properties are called xxx0 and xxx1 (as you've done to find the perturbable molecules coordinates and velocities properties). The user has freedom to use other names, but it makes the code more difficult. I've said this is the format in the new sire docs for merged molecules. It may be worth separately creating a "detailed guide" page on the BioSimSpace website describing the merged molecule layout and format.
Yes, that's a good point. I allow the user to pass a map when performing the merge (if the system has different names) but then it just uses what it finds and appends 0 and 1. |
Hmm, apparently the updated test angles weren't on this branch, despite me merging across from |
Nope, the change is there and it's built against the most recent development version of Sire. Will debug locally. I can't see that the recent Sire merge has somehow reverted the triclinic update? |
(No, not possible since other tests would fail here.) |
Ah, the issue is that the test works if you run it in isolation (as I was doing) but not if you run them all. Presumably the space is being modified by another test. Will fix and repush. |
This PR exposes functionality related to the changes to
sire.legacy.Vol.TriclinicBox
, allowing the user to manually rotate the space and perform a lattice reduction. Keywords have also been added toBioSimSpace.IO.readMolecules
to allow the user to perform these operations on load.devel
into this branch before issuing this pull request (e.g. by runninggit pull origin devel
): [y]Suggested reviewers:
@chryswoods