Allow unit-based protocol options to be passed as strings #179
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables unit-based protocol options to be passed as strings, e.g:
This means less typing and makes it easier to instantiate a protocol using settings in a configuration file. (Although none of this is a problem if using nodes.) There are other places in the code where the same approach could be applied, but this is the main point of friction. (I'll update the others as I refactor other parts.)
I've taken the opportunity to add some equality operators to make the testing easier. A lot of the changes are boiler-plate around that.
devel
into this branch before issuing this pull request (e.g. by runninggit pull origin devel
): [y]Suggested reviewers:
@chryswoods