Fix issue #180 #181
Merged
Fix issue #180 #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lohedges
temporarily deployed
to
biosimspace-build
GitHub Actions
Inactive
lohedges
temporarily deployed
to
biosimspace-build
GitHub Actions
Inactive
lohedges
temporarily deployed
to
biosimspace-build
GitHub Actions
Inactive
lohedges
temporarily deployed
to
biosimspace-build
GitHub Actions
Inactive
lohedges
temporarily deployed
to
biosimspace-build
GitHub Actions
Inactive
annamherz
approved these changes
Oct 6, 2023
annamherz
approved these changes
Oct 6, 2023
jasmin-guven
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #180 by ensuring that the
gpuconfiguration option for SOMD is always set to zero, i.e. we are using a single GPU job with whatever is the first visible device. This used to be the case when the code was first written, but somewhen it appears to have been set to the actual value of the firstCUDA_VISIBLE_DEVICESentry.develinto this branch before issuing this pull request (e.g. by runninggit pull origin devel): [y]Suggested reviewers:
@jasmin-guven, @annamherz