Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose torsion modification kwargs #302

Merged
merged 2 commits into from
Jun 18, 2024
Merged

Expose torsion modification kwargs #302

merged 2 commits into from
Jun 18, 2024

Conversation

lohedges
Copy link
Contributor

This PR exposes the dummy torsion force constant modification kwargs used by the pert file writer in the Process.Somd constructor. These aren't really used, but I want to enable them for debugging purposes. Currently they are set to False by default and can only be used if calling the pert file writer function directly.

(This isn't really a bug, since it's not used, but I did forget to expose these when adding kwargs to the process classes to capture engine specific options.)

  • I confirm that I have merged the latest version of devel into this branch before issuing this pull request (e.g. by running git pull origin devel): [y]
  • I confirm that I have permission to release this code under the GPL3 license: [y]

@lohedges lohedges added the bug Something isn't working label Jun 18, 2024
@lohedges lohedges requested a review from mb2055 June 18, 2024 11:27
@lohedges lohedges temporarily deployed to biosimspace-build June 18, 2024 11:28 — with GitHub Actions Inactive
@lohedges lohedges temporarily deployed to biosimspace-build June 18, 2024 11:28 — with GitHub Actions Inactive
@lohedges lohedges temporarily deployed to biosimspace-build June 18, 2024 11:28 — with GitHub Actions Inactive
@lohedges lohedges temporarily deployed to biosimspace-build June 18, 2024 11:28 — with GitHub Actions Inactive
@lohedges lohedges temporarily deployed to biosimspace-build June 18, 2024 11:28 — with GitHub Actions Inactive
Copy link
Contributor

@mb2055 mb2055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good 👍

@lohedges lohedges merged commit b5a8209 into devel Jun 18, 2024
5 checks passed
@lohedges lohedges deleted the fix_zero_dummy_torsions branch June 18, 2024 13:35
lohedges added a commit that referenced this pull request Jun 18, 2024
lohedges added a commit that referenced this pull request Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants