Cleanup unused files, improve build infra, add license to postgres, etc. #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These now live in the deployment-recipes repo
Moved to deployment-recipes repo
GitHub Actions (.github/workflows/unit_test.yaml) handles this instead.
Write .version using Git tag when running any make target.
Handled by Goreleaser.
|
Personally, I think if we don't use it or need it, it's probably best to get rid of it. I didn't see anything in any of the things listed that should impact BSS working like it is already. |
|
Just pushed some commits that deletes the items in question in the initial comment. If we decide we need these, we can always refer to them or revert them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up a lot of the unused files in the repository that are no longer needed. Also, improve the build infrastructure such as streamlining the Makefile and Github Actions config. Further, add the Triad license to the included postgres package.
Many of the deleted files are integration tests that have moved to deployment-recipes.
Is it worth keeping things like:
?