Generalize container image build to target other CPU architectures #26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, the target architecture for the container image can be selected with environment variables in the build environment, rather than being hard-coded into the Makefile. If the
GOOS
andGOARCH
environment variables are unspecified, the container image is built to targetlinux/amd64
, which is the same behavior as before.This has been tested with
linux/arm64
, which takes around 15 minutes to build the SMD image on a modern x86-based server.One thing I don't like about this change is that the Dockerfile now downloads a
golang
container image from the internet, which seems to conflict with software provenance goals for the project. I am not sure what is the best approach to address that.