views.py: Specific JSON parsing error

OpenDataServices · Dec 9, 2024 · 921263c · 921263c
1 parent 6c39872
commit 921263c
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 17 deletions.
diff --git a/libcoveweb2/templatetags/cove_tags.py b/libcoveweb2/templatetags/cove_tags.py
@@ -15,15 +15,15 @@ def cove_modal_list(**kw):
 @register.inclusion_tag("modal_errors.html")
 def cove_modal_errors(**context):
     if hasattr(settings, "VALIDATION_ERROR_LOCATIONS_LENGTH"):
-        context["validation_error_locations_length"] = (
-            settings.VALIDATION_ERROR_LOCATIONS_LENGTH
-        )
+        context[
+            "validation_error_locations_length"
+        ] = settings.VALIDATION_ERROR_LOCATIONS_LENGTH
     else:
         context["validation_error_locations_length"] = 1000
     if hasattr(settings, "VALIDATION_ERROR_LOCATIONS_SAMPLE"):
-        context["validation_error_locations_sample"] = (
-            settings.VALIDATION_ERROR_LOCATIONS_SAMPLE
-        )
+        context[
+            "validation_error_locations_sample"
+        ] = settings.VALIDATION_ERROR_LOCATIONS_SAMPLE
     return context
 
 

diff --git a/libcoveweb2/views.py b/libcoveweb2/views.py
@@ -149,17 +149,33 @@ def view_does_not_exist(self, request):
 
     def view_data_has_error(self, request, supplied_data):
         """Called if the supplied data has any error set."""
-        return render(
-            request,
-            self.error_template,
-            {
-                "sub_title": _("Sorry, there was an error."),
-                "link": "index",
-                "link_text": _("Go to Home page"),
-                "msg": _("There was an error."),
-            },
-            status=500,
-        )
+        if supplied_data.error.startswith("JSON: Data parsing error"):
+            return render(
+                request,
+                self.error_template,
+                {
+                    "sub_title": _("Data parsing error."),
+                    "link": "index",
+                    "link_text": _("Go to Home page"),
+                    "msg": _(
+                        "The data is not valid JSON. "
+                        + "Use a JSON validator tool to correct your data."
+                    ),
+                },
+                status=500,
+            )
+        else:
+            return render(
+                request,
+                self.error_template,
+                {
+                    "sub_title": _("Sorry, there was an error."),
+                    "link": "index",
+                    "link_text": _("Go to Home page"),
+                    "msg": _("There was an error."),
+                },
+                status=500,
+            )
 
     def view_has_expired(self, request, supplied_data):
         """Called if the data has expired and has now been deleted.