Private adaptor logs #605
Merged
Private adaptor logs #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Urgh, this is annoying. Mocking of the logger.proxy function - which I kind of need to test this fix - is a bit complicated. I'm going to pause on this, prepare the release, and come back with a fresher head on it. |
If a server is destroyed before the lightning connection returned, the workloop will still fire even if the server is technically destroyed
josephjclark
force-pushed
the
private-adaptor-logs
branch
from
0b1afab
to
322813c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Treat adaptor logs the same as job logs - don't log them to stdout and gcloud.
Closes #602