-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Worker: Update version listings #611
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basically instead of looking up the adaptor version from the global list of options, we calculate the version for each step and pass that through to execution
This lets the runtime use the repo to install the correct versions of adaptors. It might run a little slower though
We only include versions on workflow start and allow multiple adaptor versions to be printed
josephjclark
changed the base branch from
main
to
workflow-multiple-adaptors
February 23, 2024 15:09
taylordowns2000
approved these changes
Feb 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i like the output
josephjclark
force-pushed
the
better-version-printing
branch
from
February 23, 2024 17:48
2499e8e
to
c3bfed8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a bit too hard to do reliable, responsible adaptor version logging on step start. I looked at it for a while and I can't think of a good way.
The runtime WILL log the version of all imported modules (ie, the adaptor), so there is currently a record of exactly what version a step used. It's just a bit buried.
At least we have a fairly clear, accurate, high level list of all eeh versions in the workflow now. It's a bit more reliable and a bit less spammy than before.
Closes #574
Output
here's how this looks in lightning: