Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

G2P-1097: Cycle being created when there are no beneficiaries in the … #127

Merged
merged 15 commits into from
Oct 20, 2023

Conversation

dibik96
Copy link
Member

@dibik96 dibik96 commented Sep 19, 2023

…Program and G2p app category filtering

@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2023

Codecov Report

Attention: 83 lines in your changes are missing coverage. Please review.

Comparison is base (5d63cb3) 53.41% compared to head (de43ca0) 53.27%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff                @@
##           15.0-develop     #127      +/-   ##
================================================
- Coverage         53.41%   53.27%   -0.15%     
================================================
  Files               142      143       +1     
  Lines              4738     4766      +28     
  Branches            732      740       +8     
================================================
+ Hits               2531     2539       +8     
- Misses             2107     2122      +15     
- Partials            100      105       +5     
Files Coverage Δ
g2p_program_reimbursement/models/cycle.py 55.55% <ø> (+8.88%) ⬆️
g2p_program_reimbursement/models/programs.py 46.66% <ø> (+3.80%) ⬆️
g2p_programs/models/__init__.py 100.00% <100.00%> (ø)
g2p_programs/models/accounting/fund_management.py 46.80% <100.00%> (+2.57%) ⬆️
g2p_programs/models/entitlement.py 42.20% <0.00%> (-0.40%) ⬇️
g2p_programs/models/managers/program_manager.py 69.67% <60.00%> (-0.67%) ⬇️
g2p_payment_cash/models/payment_manager.py 68.75% <25.00%> (-1.53%) ⬇️
g2p_payment_g2p_connect/models/payment_manager.py 42.50% <0.00%> (-1.66%) ⬇️
..._registrant_info/models/program_registrant_info.py 47.14% <33.33%> (-1.30%) ⬇️
g2p_programs/models/disable_edit_mixin.py 63.63% <63.63%> (ø)
... and 7 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dibik96 dibik96 force-pushed the 15.0-new branch 3 times, most recently from 24a9b9c to 1841bbb Compare October 3, 2023 15:18
@shibu-narayanan shibu-narayanan merged commit 9e1ab85 into OpenG2P:15.0-develop Oct 20, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants