G2P-1499: Able to send payments without preparing payment batch

g2p_payment_cash/models/payment_manager.py

@@ -47,22 +47,25 @@ class G2PPaymentManagerCash(models.Model):
 
     # This will just mark all the payments as done when then cash is given out
     def _send_payments(self, batches):
-        _logger.info("DEBUG! send_payments Manager: Payment via CASH")
-        for batch in batches:
-            batch.batch_has_started = True
-            for payment in batch.payment_ids:
-                payment.update(
-                    {
-                        "state": "reconciled",
-                        "status": "paid",
-                        "amount_paid": payment.amount_issued,
-                        "payment_datetime": datetime.utcnow(),
-                    }
-                )
-            batch.batch_has_completed = True
-
-        message = _("Payment files created successfully")
-        kind = "success"
+        if not batches:
+            message = _("No payment batches to process.")
+            kind = "danger"  # Use a valid type like "danger" for an error message
+        else:
+            _logger.info("DEBUG! send_payments Manager: Payment via CASH")
+            for batch in batches:
+                batch.batch_has_started = True
+                for payment in batch.payment_ids:
+                    payment.update(
+                        {
+                            "state": "reconciled",
+                            "status": "paid",
+                            "amount_paid": payment.amount_issued,
+                            "payment_datetime": datetime.utcnow(),
+                        }
+                    )
+                batch.batch_has_completed = True
+            message = _("Payment files created successfully")
+            kind = "success"
         return {
             "type": "ir.actions.client",
             "tag": "display_notification",

g2p_programs/models/managers/payment_manager.py

@@ -235,6 +235,32 @@ def _prepare_payments_async(self, cycle, entitlements, entitlements_count):
         )
         main_job.delay()
 
+    def send_payments(self, batches):
+        # TODO: Return client action with proper message.
+        batches_count = len(batches)
+        if batches_count < self.MAX_BATCHES_FOR_SYNC_SEND:
+            return self._send_payments(batches)
+        else:
+            cycles, cycle_batches = self._group_batches_by_cycle(batches)
+            for batches in cycle_batches:
+                cycle = batches[0].cycle_id
+                self._send_payments_async(cycle, batches)
+            message = _("Sending Payments Asynchronously")
+            kind = "success"
+            return {
+                "type": "ir.actions.client",
+                "tag": "display_notification",
+                "params": {
+                    "title": _("Payment"),
+                    "message": message,
+                    "sticky": True,
+                    "type": kind,
+                    "next": {
+                        "type": "ir.actions.act_window_close",
+                    },
+                },
+            }
+
     def _send_payments(self, batches):
         # Create a payment list (CSV)
         # _logger.debug("DEBUG! send_payments Manager: DEFAULT")
@@ -299,32 +325,6 @@ def _send_payments(self, batches):
             },
         }
 
-    def send_payments(self, batches):
-        # TODO: Return client action with proper message.
-        batches_count = len(batches)
-        if batches_count < self.MAX_BATCHES_FOR_SYNC_SEND:
-            return self._send_payments(batches)
-        else:
-            cycles, cycle_batches = self._group_batches_by_cycle(batches)
-            for batches in cycle_batches:
-                cycle = batches[0].cycle_id
-                self._send_payments_async(cycle, batches)
-            message = _("Sending Payments Asynchronously")
-            kind = "success"
-            return {
-                "type": "ir.actions.client",
-                "tag": "display_notification",
-                "params": {
-                    "title": _("Payment"),
-                    "message": message,
-                    "sticky": True,
-                    "type": kind,
-                    "next": {
-                        "type": "ir.actions.act_window_close",
-                    },
-                },
-            }
-
     def _send_payments_async(self, cycle, batches):
         _logger.debug("Send Payments asynchronously")
         cycle.message_post(