Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ReadPair's never being freed #515

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Donwulff
Copy link

Fixes memory leak in PairEndProcessor::interleavedReaderTask() where ReadPair objects were not being freed, resulting in a leak of 16 bytes per read pair across the input (Issue #392 ).

Changes:

  • Modified call signatures to reuse the same ReadPair for all reads, as it's a return container for the Read pairs.
  • Added a method to detect the end of input for clarity.
  • Updated freeing of the Read arrays to utilize array delete.

Performance Metrics Comparison on 1KG HG00312 exome with 110M reads:

Metric Before After
User time (seconds) 1524.60 1507.94
Maximum resident set size (kbytes) 4423400 2548668

All results remained identical.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant