AO-870: Create a UI module to manage mailing list for facility syncho report #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdulko-soldevelo
suggested changes
Jul 16, 2024
| <div class="modal-dialog"> | ||
| <div class="modal-content"> | ||
| <div class="modal-header"> | ||
| <h1>{{vm.modalHeaderKey | message}}</h1> |
There was a problem hiding this comment.
please add one-time bindings, for example {{:: vm.modalHeaderKey | message}} for all texts, if the value will not be changed
https://docs.angularjs.org/guide/expression#one-time-binding
| <h2>{{'adminIntegrationEmailList.header' | message}}</h2> | ||
| <section class="openlmis-table-container"> | ||
| <button id="add-email" class="add" ui-sref="openlmis.administration.adminIntegrationEmailList.add"> | ||
| {{'adminIntegrationEmailList.addEmail' | message}} |
There was a problem hiding this comment.
same as above, if the text is not changed or being affected by ng-repeat, use one time binds
|
mdulko-soldevelo
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket:
https://openlmis.atlassian.net/browse/AO-870
Changes:
Added possibility to manage integration emails from the administration panel