Remove dependency pom #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Wisniewski <[email protected]>
scottkurz
approved these changes
Dec 11, 2024
|
The only difference in the config was specifying the dependency pom location as a maven arg. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are removing the dependency pom for two reasons:
The list of Eclipse platform dependencies do not need to be scanned as these are considered part of the "platform" were the plugin is running and not the product we ship. Without these, this only leaves the LS dependencies.
Scanning the repository without specifying a dedicated pom scans the LS dependencies (they are defined in the lsp4e bundle pom) and also ends up scanning all of the transitive dependencies of the language server jars. This gives a more complete scan.