rename files to match OG naming scheme, and update dat names as well #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure this makes sense. Why would you expect the A2 for example to be in a file called A3? |
Why did we make an A2 to replace an A3? But I thought more about it and I guess I'm fine leaving the names as they are (ie abandon the pr), because I think you're right, the file name should match the content of that file. By my own words I said these vehicles should be fantasy vehicles with made up names, so that would mean renaming the files like I did here is wrong, and instead of making an "A2" we should be inventing a new name for it (and all the other new assets) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vehicles we added don't match the naming scheme we decided on. This PR updates those names, both filename and internal dat name