Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New test for groupprivate 6.0 #842

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

New test for groupprivate 6.0 #842

wants to merge 11 commits into from

Conversation

rjenaa
Copy link
Collaborator

@rjenaa rjenaa commented Oct 31, 2024

No description provided.

@rjenaa rjenaa added in progress PR created, we are working on it 6.0 labels Oct 31, 2024
@rjenaa rjenaa self-assigned this Oct 31, 2024
@spophale
Copy link
Collaborator

spophale commented Nov 5, 2024

@seyonglee , @rjenaa Our usage is correct. Only thing is that the pragma needs to go right after the declaration. To keep it simple, lets get rid of the nohost. That is an unnecessary level of complication.

@spophale
Copy link
Collaborator

spophale commented Nov 7, 2024

@jrreap next steps:
Same test + device_type(any) -- no other change required
Same test + device_type(host) -- remove target directive
Same test + device_type(nohost) -- function should also be declared noohost

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.0 in progress PR created, we are working on it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants