Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Added Mathematical Notation & few changes #178

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from

Conversation

Telomelonia
Copy link

@Telomelonia Telomelonia commented Dec 5, 2022

Describe the change

  • Chemical Struct of L-alanine was added for a reference wrt to SMILES.
  • Few render issues in here. I think ** strong emphasis ** is not able to render.
  • Rendering of Math equation properly here.
  • One typo... position of Bracket is wrong here.
  • chemical struct in glossary

resolves #136

These changes are just from tutorials.

Queries

  • I want to add mathematical notation in Glossary, too( like $MS^{2}$, $MS^{1}$). Can someone guide me on how I could make changes to Glossary?
  • The Text(** Word **) mentioned in Description points no. 2 are they intentional or just render issue?
  • I found few math equation in introduction directory in extended-background.md.
  • How to resolve the failure of CI.

PR checklist

Chemical Struct of L-alarine was added for a reference wrt to SMILES.
Rendering of math equation was not proper
bracket position wrong
@Telomelonia Telomelonia changed the title Added Mathematical Notation & few changes [DOC] Added Mathematical Notation & few changes Dec 5, 2022
@timosachsenberg
Copy link
Contributor

thanks for your contribution! we will look into it

@Telomelonia Telomelonia marked this pull request as ready for review January 23, 2023 23:52
@@ -1263,7 +1272,7 @@ false IDs by separating target IDs from decoy IDs.

ROC curves illustrate the discriminative capability of the scores of IDs. In the case of protein identifications, Fido produces the posterior probability of each protein as
the output score. However, a perfect score should not only be highly discriminative (distinguishing true from false IDs), it should also be “calibrated” (for probability indicating that all IDs with reported posterior probability scores of 95% should roughly have a 5% probability of being false. This implies that the estimated number of false
positives can be computed as the sum of posterior error probabilities ( = 1 - posterior probability) in a set, divided by the number of proteins in the set. Thereby a
positives can be computed as the sum of posterior error probabilities = (1 - posterior probability) in a set, divided by the number of proteins in the set. Thereby a
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I liked the other notation better.

@@ -22,7 +22,7 @@ FASTA format
A text-based format for representing nucleotide or amino acid sequences.

octadecyl (C18)
An alkyl radical C(18)H(37) derived from an octadecane by removal of one hydrogen atom.
An alkyl radical :math:`C_{18}H_{37}` derived from an octadecane by removal of one hydrogen atom.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a screenshot of this? From my experience, this will treat C and H as mathematical variables, which is not what we want.
Better to use :sub: for subscripts.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, just tested and it is not correct.
Please use :sub: for stoichiometric coefficients and :sup: for isotopes instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use markdown mathematical notations
4 participants