Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for compiling under OSX 10.8 with clang #35

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ChristianFrisson
Copy link

Hi,

Some private fields in OpenNI2 classes are colliding with Apple LLVM version 4.2 (clang-425.0.28) (based on LLVM 3.2svn) that uses -Werror,-Wunused-private-field. So as to make OpenNI2 compile, it did 2 kinds of hacks:

  • promoting from private to protected
  • commenting out the unused private class members.

I don't know about the OpenNI2 architecture, hence the hacks. Could you please review these?

Best regards,
Christian

…(clang-425.0.28) (based on LLVM 3.2svn) that uses -Werror,-Wunused-private-field
@tomoto
Copy link
Collaborator

tomoto commented Aug 27, 2013

IMHO, disallowing ANY unused private field is too strict and counter-productive especially when the code is in the beta status. As you rightly say it is a "hack", promoting private to protected just because the compiler complains does not make sense. I think the reasonable solution is "not" to treat unused private field as an error. Perhaps -Wno-error=unused-private-field would work?

@yingshixiaohu
Copy link

Hi,
I am a Software developer in Beijing,I have a question need your help.
I want to setting videostream through videomode, but it didn't work.
Then i call the openni's getExtendedError function,it return "Stream setProperty(3) failed ",
I want to know what's wrong with it,can you help me?

ing4shubowei

@dankegel
Copy link

You can work around this with

make ALLOW_WARNINGS=1

SebasRatz pushed a commit to SebasRatz/OpenNI2 that referenced this pull request Aug 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants