PointSymbolEditorWidget: Don't duplicate CurveStart property #2093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Waiting for #2091 to be merged. |
When adding a path point by clicking on the '+' button either a default point is appended to the path or an existing path point is duplicated. However, when duplicating an existing point, also the CurveStart property was duplicated which lead to two successive path points with a set CurveStart property although the next two path points following a CurveStart path point define the course of the curve and thus can't be a CurveStart path point itself. Closes OpenOrienteeringGH-2090 (Symbol Editor: Cannot remove coordinate pairs).
When adding a path point by the '+' button the symbol was not updated. Since the point is normally duplicated this had no visual impact. However, if no row is selected then a default point at (0,0) is created which was not shown in this case.
When the 'Line closed' checkmark was set and all lines were removed the checkbox remained set but became disabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding a path point by clicking on the '+' button either a default point is appended to the path or an existing path point is duplicated.
However, when duplicating an existing point, also the CurveStart property was duplicated which lead to two successive path points with a set CurveStart property although the next two path points following a CurveStart path point define the course of the curve and thus can't be a CurveStart path point itself.
Resolves #2090
Another fix addresses the issue that a default point that was added was not shown immediately.
Finally there was the issue that removing line parts disabled the 'Line closed' checkbox but did not remove the checkmark.