GeoreferencingDialog: Fix declination lookup #2255
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The declination lookup at www.ngdc.noaa.gov requests an additional parameter 'key'. OpenOrienteering Mapper is entitled due to registration to use the key which is also used by the Magnetic Field Calculators' homepage.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
lpechacek
approved these changes
Jul 30, 2024
There was a problem hiding this comment.
Ack on this one. I believe that this straightforward implementation suffices.
FTR, I took a slightly different route in LibreMapper (LibreMapper/mapper@6c2fd6c), giving the user opportunity to enter an alternate key when the declination lookup fails. On the other hand, I doubt that the key will change without an advance notice. That makes the extra code mostly useless if not harmful. Time will show...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The declination lookup at www.ngdc.noaa.gov requests an additional parameter 'key'. OpenOrienteering Mapper is entitled due to registration to use the key which is also used by the Magnetic Field Calculators' homepage.
This PR is a straightforward version of #2088 and thus might supersede it.