Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add backport of Qt 5.15 Android content URI support #88

Draft
wants to merge 1 commit into
base: qt-5.12-openorienteering
Choose a base branch
from

Conversation

dg0yt
Copy link
Member

@dg0yt dg0yt commented Mar 7, 2021

No description provided.

Copy link
Member Author

@dg0yt dg0yt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional changes needed.

+
+ String visitedUri = matchedTreeUri.toString();
+ while (true) {
+ Log.w(QtTAG, "*** VISITING: " + visitedUri);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Remove this logging entry.

+ String visitedUri = matchedTreeUri.toString();
+ while (true) {
+ Log.w(QtTAG, "*** VISITING: " + visitedUri);
+ // Populate m_cachedUris with children of matchedTreeUri
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/matchedTreeUri/visitedUri/


public static boolean openURL(Context context, String url, String mime)
{
+ url = getCanonicalContentUri(url);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Limit this to content: URIs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant