Improve dependency handling #89
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than adding extra "virtual" packages without build rules, let packages directly declare which alias names they provide, and make use of these aliases during dependency resolution. This helps to to reduce the complexity of the generated build system. User benefit from shorter lists of targets in IDE and at the command line, and from a reduced number of nodes in dependency graphs.
Package which do not have build rules (except source setup) and which do not depend on any binary package shall not be transformed into binary targets. Such binary targets might be convenient for use as "meta packages". But for Superbuild, we prefer explicit dependencies.
|
Just for the record, with custom dot file generation in CMakeLists.txt, it would be possible to group targets in a different way. The following example groups targets by cmake script using "records":
|
|
Focusing this PR on graphviz support and reduction of targets. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create less custom targets.
Generate and publish dependency graph document.