Removed tags deprecation warnings, fixed antipatterns

OpenPonk · Nov 16, 2024 · e0501e5 · e0501e5
1 parent 2ca178a
commit e0501e5
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 13 deletions.
diff --git a/OpenPonk-OntoUML-Verifications/OntoUMLVerificationUpdater.class.st b/OpenPonk-OntoUML-Verifications/OntoUMLVerificationUpdater.class.st
@@ -65,7 +65,7 @@ OntoUMLVerificationUpdater >> getVerifications [
 
 	^ (self packageOrganizer packageNamed:
 		   'Openponk-OntoUML-Verifications') definedClasses select: [ :class |
-		  class tags asSet includes: 'Verification-Classes' "or: (class tags asSet includes: 'Antipattern-Classes')" ]
+		  class packageTag name = 'Verification-Classes' "or: [ class packageTag name = 'Antipattern-Classes' ]" ]
 ]
 
 { #category : 'constants' }

diff --git a/OpenPonk-OntoUML-Verifications/VerificationController.class.st b/OpenPonk-OntoUML-Verifications/VerificationController.class.st
@@ -32,16 +32,18 @@ VerificationController >> detectAntiPatternsIn: aVerifiedModel [
 
 { #category : 'verification' }
 VerificationController >> getAntiPatternVerifications [
-	^ (self packageOrganizer packageNamed: 'Openponk-OntoUML-Verifications')
-		definedClasses
-		select: [ :class | class tags asSet includes: 'Antipattern-Classes'. ].
+
+	^ (self packageOrganizer packageNamed:
+		   'OpenPonk-OntoUML-Verifications') definedClasses select: [ :class |
+		  class packageTag name = 'Antipattern-Classes' ]
 ]
 
 { #category : 'verification' }
 VerificationController >> getVerifications [
-	^ (self packageOrganizer packageNamed: 'OpenPonk-OntoUML-Verifications')
-		definedClasses
-		select: [ :class | class tags asSet includes: 'Verification-Classes' ].
+
+	^ (self packageOrganizer packageNamed:
+		   'OpenPonk-OntoUML-Verifications') definedClasses select: [ :class |
+		  class packageTag name = 'Verification-Classes' ]
 ]
 
 { #category : 'verification' }

diff --git a/OpenPonk-OntoUML-Verifications/VerificationControllerTest.class.st b/OpenPonk-OntoUML-Verifications/VerificationControllerTest.class.st
@@ -8,23 +8,35 @@ Class {
 
 { #category : 'tests' }
 VerificationControllerTest >> testGetAntiPatternVerifications [
-	| controller antiPatternVerifications  |
+
+	| controller antiPatternVerifications |
 	controller := VerificationController new.
 	antiPatternVerifications := controller getAntiPatternVerifications.
 	self assert: (antiPatternVerifications isKindOf: Collection).
-	self assert: (antiPatternVerifications isEmpty) equals: false.
-	self assert: (antiPatternVerifications allSatisfy: [ :verificationClass | verificationClass tags asSet includes: 'Antipattern-Classes'. ]) equals: true.
+	self assert: antiPatternVerifications isEmpty equals: false.
+	self
+		assert:
+			(antiPatternVerifications allSatisfy: [ :verificationClass |
+				 verificationClass packageTag name = 'Antipattern-Classes' ])
+		equals: true
 ]
 
 { #category : 'tests' }
 VerificationControllerTest >> testGetVerifications [
+
 	| controller verifications |
 	controller := VerificationController new.
 	verifications := controller getVerifications.
 	self assert: (verifications isKindOf: Collection).
-	self assert: (verifications isEmpty) equals: false.
-	self assert: (verifications anySatisfy: [ :verificationClass | verificationClass = Verification ]) equals: true.
-	self assert: (verifications allSatisfy: [ :verificationClass | verificationClass tags asSet includes: 'Verification-Classes'. ]) equals: true.
+	self assert: verifications isEmpty equals: false.
+	self
+		assert: (verifications anySatisfy: [ :verificationClass |
+				 verificationClass = Verification ])
+		equals: true.
+	self
+		assert: (verifications allSatisfy: [ :verificationClass |
+				 verificationClass packageTag name = 'Verification-Classes' ])
+		equals: true
 ]
 
 { #category : 'tests' }