Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix compilation on macOS 12 #67

Merged
merged 2 commits into from
Mar 21, 2023
Merged

fix compilation on macOS 12 #67

merged 2 commits into from
Mar 21, 2023

Conversation

keisisqrl
Copy link
Contributor

Fixes issue #66

@keisisqrl keisisqrl closed this Mar 14, 2022
@keisisqrl
Copy link
Contributor Author

Breaks build on 11... working on this.

removing -Werror would also work, but avoiding warnings is... better.

@keisisqrl keisisqrl reopened this Mar 14, 2022
@keisisqrl
Copy link
Contributor Author

keisisqrl commented Mar 14, 2022

Compiles on macOS 12 and macOS 11.5, I don't have anything else to test. As documented in comments this uses clang features to gate the new functionality and C pragmas to quiet it about the deprecated definition. It may break in future if kIOMasterPortDefault is moved from deprecated to obsolete but for now, here's a fix.

@keisisqrl
Copy link
Contributor Author

Builds on macOS 13 as well.

@NoelM
Copy link

NoelM commented Nov 30, 2022

Thanks for the patch! I was doing the same based on the Availability.h provided by Apple, with their recommended implementation:
NoelM/dmrconfig@master...bug/fix-mac-os-12+-builds

Could you tell me if there's a difference with pragmas? Also I see you PR stuck for a while, nobody maintains this package?

@silseva
Copy link

silseva commented Dec 2, 2022

Hi!
We're trying to restart maintaining dmrconfig, after Serge decided to move it under the OpenRTX organization since, at the moment, he cannot actively work on it.
About the differences between this solution and @NoelM 's one: the main one is that the one based on pragmas does the selection at compile time, which will prevent the arising of deprecation warnings or similar stuff.

@wp4nuv
Copy link

wp4nuv commented Mar 20, 2023

Hi! We're trying to restart maintaining dmrconfig, after Serge decided to move it under the OpenRTX organization since, at the moment, he cannot actively work on it. About the differences between this solution and @NoelM 's one: the main one is that the one based on pragmas does the selection at compile time, which will prevent the arising of deprecation warnings or similar stuff.

I'm sorry, but does this mean he's the only one who can approve this PR?

@silseva
Copy link

silseva commented Mar 21, 2023

No. :)
I didn't merged this PR before because, not having a Mac OS computer, I cannot determine what is the better choice between this and the #70. I'm now going to merge this and, if some issues arise, we'll see how to handle them.

@silseva silseva merged commit 1f5e5dd into OpenRTX:master Mar 21, 2023
@keisisqrl keisisqrl deleted the fix-io-main branch March 21, 2023 19:05
@turnrye turnrye mentioned this pull request Aug 6, 2023
@garthk garthk mentioned this pull request Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants