Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Budgets Project filters Ambiguous ID #149

Merged
merged 4 commits into from
Dec 19, 2023
Merged

Conversation

Quentinchampenois
Copy link
Contributor

@Quentinchampenois Quentinchampenois commented Dec 15, 2023

🎩 Description

Please describe your pull request.

When filtering, it causes a 500 error

 ActionView::Template::Error (PG::AmbiguousColumn: ERROR:  column reference "id" is ambiguous
oncat(',', id::text, ',') in ',,')...
           ^
      5: </div>
      6: 
      7: <div class="budget-list">
      8:   <% projects.each do |project| %>
      9:     <%= render partial: "project", locals: { project: project } %>
     10:     <%= render partial: "project_modal", locals: { project: project } %>
     11:   <% end %>

📌 Related Issues

Link your PR to an issue

Testing

Describe the best way to test or validate your PR.

Example:

  • Go to budgets
  • Try to filter
  • You should not have 500 error

@Quentinchampenois Quentinchampenois marked this pull request as ready for review December 18, 2023 12:28
@Quentinchampenois Quentinchampenois requested review from a team, AyakorK and luciegrau and removed request for a team December 18, 2023 12:28
@Quentinchampenois Quentinchampenois requested review from moustachu and removed request for AyakorK December 18, 2023 14:05
@moustachu moustachu merged commit 35d8823 into develop Dec 19, 2023
10 checks passed
@moustachu moustachu deleted the fix/budgets_order branch December 19, 2023 09:42
Quentinchampenois added a commit that referenced this pull request Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants