Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove endorsements from the proposal page #49

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

AyakorK
Copy link
Contributor

@AyakorK AyakorK commented Jul 22, 2024

🎩 Description

Please describe your pull request.

This PR removes the endorsements from a proposal page which could cause some problems when there was a lot of endorsements for a single proposal

📌 Related Issues

Testing

Describe the best way to test or validate your PR.

Example:

  • Log in as user
  • Access a process
  • Access to proposals
  • Check a proposal that has endorsements
  • Make sure that you don't have the list of endorsements when accessing to the page of the proposal

Tasks

  • Override the file to remove the endorsement list
  • Add missing locales

📷 Screenshots

Please add screenshots of the changes you're proposing if related to the UI

@AyakorK AyakorK marked this pull request as ready for review July 22, 2024 14:16
Copy link
Contributor

@luciegrau luciegrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works locally, thank you!

@luciegrau luciegrau merged commit d420571 into develop Jul 22, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants