Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump simple proposal to fix selected scope method #100

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

luciegrau
Copy link
Contributor

@luciegrau luciegrau commented Sep 3, 2024

🎩 Description

Bump of updated decidim-module-simple_proposal

📌 Related Issues

Testing

  • As an admin, go to a process and then to budgets
  • Click on "Manage projects" of a budget (cf screenshot one)
  • Go to the edit of a project which has a scope (cf screenshot two)
  • In the edit view, see that the scope is selected (cf screenshot three)
363596503-e5575e3c-95d1-439e-829a-cdaf3a41e8da 363596820-1bb084de-99c0-4127-8c13-05c6e8fd28e8 363597047-904a54fa-b836-4207-a42f-9affcfcf4535

@luciegrau luciegrau marked this pull request as ready for review September 3, 2024 10:15
Copy link
Contributor

@Stef-Rousset Stef-Rousset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@luciegrau luciegrau merged commit 14bd3ed into develop Sep 3, 2024
14 checks passed
@luciegrau luciegrau deleted the bump/fix_selected_scope_method branch September 3, 2024 13:02
moustachu pushed a commit that referenced this pull request Sep 5, 2024
Quentinchampenois added a commit that referenced this pull request Oct 9, 2024
* fix: Modify default proposal states (#77)

* feat: Addition of Extra User Fields Module (#79)

* feat: Add Extra User Fields

* lint: Rubocop Fixes

* feat: Add Friendly Signup (#78)

* feat: Add friendly signup

* feat: Add configurable options to the config

* fix: Fix some tests and add new ones

* fix: Missing text modification

* chore: Merge Extra user fields

---------

Co-authored-by: quentinchampenois <[email protected]>

* feat: Add module budget booth (#81)

* feat: Add module budget booth

* bump: modules

* ci: Add x86_64 linux support

* test: Explore projects index

* feat: Modules simple proposals & paper ballots (#82)

* fix: Add simple proposals

* lint: Fix rubocop offenses

* fix: Select first photo in proposal form

* test: Add Custom proposals factories

* fix: Downgrade to decidim v0.27.5

* chore: Update db schema.rb

* fix: Add simple proposals migration

* chore: Update db schema.rb

* revert: Gemfile locked to 0.27.5

* ci: Add x86_64 linux support

* test: Fix proposal fields in system specs

* test: Fix simple proposal system specs

* test: Remove broken specs

* test: Remove broken specs

* test: Category id is optional

* bump: Module simple proposal

* feat: Module paper ballots (#83)

* feat: Add module paper ballots

* chore: Update README and schema.rb

* lint: Fix rubocop offenses

* feat: Add module budgets_importer (#84)

* feat:module_budgets_importer

* feat:budgets_importer add/bumb rspec

* delete rspec

---------

Co-authored-by: Quentin Champenois <[email protected]>

* fix: Override budgets importer projects index

* fix: incompat paper ballots and budgets importer

* ci: ignore missing locales

* fix: add french translation key for paper_ballot module (#88)

* fix:budget_importer (#89)

* bump: Bump of simple proposal module (#90)

* fix: Change branch of simple proposal module

* fix: Bump simple proposal module

* fix: Downgrade wicked pdf (#91)

* chore: Update docker compose command

* fix(config): Force Rack attack to false

* Upgrade decidim-custom_proposal_states (#92)

* Update awesome with private fields (#93)

* update awesome with private fields

* use merged branch

* fix: migration FixReferenceForAllResources when table does not exists

* bump fix notifications and mails send after voting (#96)

* Bump: simple_proposal update (#97)

* Bump: simple_proposal update

* test: update system test

* Fix: Bump Decidim Awesome module (#95)

* Fix export dropdown in admin proposals index (#98)

* fix: add missing translation keys

* test: update config file after i18n test

* Bump simple proposal module (#100)

* fix: Add missing Sidekiq queues (#101)

* fix(sidekiq): duplicate sidekiq queue (#102)

The queue `user_report` is duplicated

---------

Co-authored-by: Guillaume MORET <[email protected]>
Co-authored-by: ’Barbara Oliveira <[email protected]>
Co-authored-by: Lucie Grau <[email protected]>
Co-authored-by: Alexandru Emil Lupu <[email protected]>
Co-authored-by: Ivan Vergés <[email protected]>
Co-authored-by: moustachu <[email protected]>
Co-authored-by: stephanierousset <[email protected]>
Quentinchampenois added a commit that referenced this pull request Oct 10, 2024
* fix: Modify default proposal states (#77)

* feat: Addition of Extra User Fields Module (#79)

* feat: Add Extra User Fields

* lint: Rubocop Fixes

* feat: Add Friendly Signup (#78)

* feat: Add friendly signup

* feat: Add configurable options to the config

* fix: Fix some tests and add new ones

* fix: Missing text modification

* chore: Merge Extra user fields

---------

Co-authored-by: quentinchampenois <[email protected]>

* feat: Add module budget booth (#81)

* feat: Add module budget booth

* bump: modules

* ci: Add x86_64 linux support

* test: Explore projects index

* feat: Modules simple proposals & paper ballots (#82)

* fix: Add simple proposals

* lint: Fix rubocop offenses

* fix: Select first photo in proposal form

* test: Add Custom proposals factories

* fix: Downgrade to decidim v0.27.5

* chore: Update db schema.rb

* fix: Add simple proposals migration

* chore: Update db schema.rb

* revert: Gemfile locked to 0.27.5

* ci: Add x86_64 linux support

* test: Fix proposal fields in system specs

* test: Fix simple proposal system specs

* test: Remove broken specs

* test: Remove broken specs

* test: Category id is optional

* bump: Module simple proposal

* feat: Module paper ballots (#83)

* feat: Add module paper ballots

* chore: Update README and schema.rb

* lint: Fix rubocop offenses

* feat: Add module budgets_importer (#84)

* feat:module_budgets_importer

* feat:budgets_importer add/bumb rspec

* delete rspec

---------

Co-authored-by: Quentin Champenois <[email protected]>

* fix: Override budgets importer projects index

* fix: incompat paper ballots and budgets importer

* ci: ignore missing locales

* fix: add french translation key for paper_ballot module (#88)

* fix:budget_importer (#89)

* bump: Bump of simple proposal module (#90)

* fix: Change branch of simple proposal module

* fix: Bump simple proposal module

* fix: Downgrade wicked pdf (#91)

* chore: Update docker compose command

* fix(config): Force Rack attack to false

* Upgrade decidim-custom_proposal_states (#92)

* Update awesome with private fields (#93)

* update awesome with private fields

* use merged branch

* fix: migration FixReferenceForAllResources when table does not exists

* bump fix notifications and mails send after voting (#96)

* Bump: simple_proposal update (#97)

* Bump: simple_proposal update

* test: update system test

* Fix: Bump Decidim Awesome module (#95)

* Fix export dropdown in admin proposals index (#98)

* fix: add missing translation keys

* test: update config file after i18n test

* Bump simple proposal module (#100)

* fix: Add missing Sidekiq queues (#101)

* fix(sidekiq): duplicate sidekiq queue (#102)

The queue `user_report` is duplicated

* chore: Push version v0.4.1

---------

Co-authored-by: Guillaume MORET <[email protected]>
Co-authored-by: ’Barbara Oliveira <[email protected]>
Co-authored-by: Lucie Grau <[email protected]>
Co-authored-by: Alexandru Emil Lupu <[email protected]>
Co-authored-by: Ivan Vergés <[email protected]>
Co-authored-by: moustachu <[email protected]>
Co-authored-by: stephanierousset <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants