-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/add decrypted private body to extra fields #105
Feat/add decrypted private body to extra fields #105
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍 I also ran it and that works 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me !
For next iterations, we should move the rake task to a dedicated Job and update extra_fields with batches in case of heavy database
🎩 Description
Add new column on ProposalExtraField to store decrypted private body date, and add rake task to update existing data.
📌 Related Issues
Testing
You may need to test this in docker if you can't add private fields in local
Decidim::DecidimAwesome::ProposalExtraField.last
, and that it contains a decrypted_private_body that looks like "<xml><dl class=\"decidim_awesome-custom_fields\" data-generator=\"decidim_awesome\ (........) </dl></xml>
"To test the rake task:
Decidim::DecidimAwesome::ProposalExtraField.last.update_columns(decrypted_private_body: nil)
(if in docker, rundocker compose exec app rails console
)bundle exec rake decidim:set_decrypted_private_body
(or in dockerdocker compose run app rake decidim:set_decrypted_private_body
)Tasks
📷 Screenshots
Please add screenshots of the changes you're proposing if related to the UI