Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signup form RGAA compliance #1235

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from
Draft

Signup form RGAA compliance #1235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3f29e9b
fix: Move TOS error into P tag
Quentinchampenois Dec 3, 2024
ebef478
fix: Remove Size attribute from password field
Quentinchampenois Dec 3, 2024
c0d9cf1
fix: contrast color in form error text
Stef-Rousset Dec 3, 2024
e6bbd45
refactor: rubocop update
Stef-Rousset Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion decidim-core/lib/decidim/assets/tailwind/tailwind.config.js.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ module.exports = {
secondary: withOpacity("--secondary-rgb"),
tertiary: withOpacity("--tertiary-rgb"),
success: "#28A745",
alert: "#ED1C24",
alert: "#ad1419",
warning: "#FFB703",
black: "#020203",
gray: {
Expand Down
1 change: 1 addition & 0 deletions decidim-core/lib/decidim/form_builder.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ def password_field(attribute, options = {})
field attribute, options do |opts|
opts[:autocomplete] ||= :off
opts[:class] ||= "input-group-field"
opts[:size] = nil
super(attribute, opts)
end
end
Expand Down
4 changes: 2 additions & 2 deletions decidim-core/lib/decidim/legacy_form_builder.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,8 @@ def error_for(attribute, options = {})

error_messages = object.errors[attribute].join(", ")
error_messages = error_messages.html_safe if options[:html_safe_errors]
content_tag(:small, error_messages,
class: class_name.sub("is-invalid-input", ""))
content_tag :p, content_tag(:small, error_messages,
class: class_name.sub("is-invalid-input", ""))
end

private
Expand Down
Loading