Fix(rgaa): Nav attributes and aria-current for accessibility compliance #1239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BarbaraOliveira13
changed the title
BarbaraOliveira13
changed the title
BarbaraOliveira13
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
BarbaraOliveira13
changed the title
Quentinchampenois
requested changes
Dec 18, 2024
| @@ -10,7 +10,7 @@ | |||
| </header> | |||
|
|
|||
| <div class="vertical-tabs"> | |||
| <nav> | |||
| <nav role="navigation" aria-label="Sous menu - <%= translated_attribute(page.title) %>"> | |||
There was a problem hiding this comment.
Suggested change
| <nav role="navigation" aria-label="Sous menu - <%= translated_attribute(page.title) %>"> | |
| <nav role="navigation" aria-label="<%= i18n.t(".navigation.aria_label", title: translated_attribute(page.title)) %>"> |
There was a problem hiding this comment.
Translation key could just be aria_label
There was a problem hiding this comment.
thanks, changes made 👍
Quentinchampenois
requested changes
Dec 19, 2024
| @@ -21,7 +21,7 @@ | |||
| <ul id="dropdown-menu-pages" class="vertical-tabs__list" role="menu"> | |||
| <% pages.each do |sibling| %> | |||
| <li class="<%= "is-active" if page == sibling %>" role="menuitem"> | |||
| <%= link_to translated_attribute(sibling.title), page_path(sibling.slug) %> | |||
| <%= link_to translated_attribute(sibling.title), page_path(sibling.slug), aria_current: ("true"if page == sibling) %> | |||
There was a problem hiding this comment.
Suggested change
| <%= link_to translated_attribute(sibling.title), page_path(sibling.slug), aria_current: ("true"if page == sibling) %> | |
| <%= link_to translated_attribute(sibling.title), page_path(sibling.slug), aria_current: (page == sibling).to_s %> |
There was a problem hiding this comment.
Condition in itself returns a TrueClass or FalseClass, you can use the condition return as string directly
Quentinchampenois
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What?
Two parts:
🎩 Why?
This issue originates from an accessibility audit funded by the city of Lyon, targeting compliance with RGAA and corresponding WCAG standards. The changes ensure clearer navigation and improved usability for assistive technologies.
📌 Related Issues
📋 Subtasks
CHANGELOGentry📷 Screenshots (optional)