Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New gradient background for "No image available." #32

Merged
merged 2 commits into from
Sep 15, 2024
Merged

Conversation

kfogel
Copy link
Member

@kfogel kfogel commented Sep 5, 2024

No description provided.

@kfogel kfogel changed the title Gray gradient background for "No image available." New gradient background for "No image available." Sep 5, 2024
@reefdog
Copy link
Collaborator

reefdog commented Sep 12, 2024

@kfogel Well, discovered a flow issue here on GitHub.

I couldn't merge in your PR because it was out of date with main, so I used GitHub's interface support for doing a rebase from main — which worked! Except it means the rebase commit is no longer signed by you (and in fact it fraudulently gave me co-author credit), which conflicts with one of our (very good) rules requiring all commits to main be signed. Clearly I should have RTFM.

Could I ask you re-apply your commit to a fresh main locally, and then either force-push to this branch or just close the PR and open a new one? (I prefer the former, but am not picky.)

Sorry for the trouble.

@kfogel
Copy link
Member Author

kfogel commented Sep 13, 2024

@reefdog Will do right now, sure. One sec.

@kfogel
Copy link
Member Author

kfogel commented Sep 13, 2024

Please try it now, @reefdog.

@reefdog
Copy link
Collaborator

reefdog commented Sep 13, 2024

@kfogel Huh… I can see that you force-pushed a Solo Karl Fogel Commit™, but it doesn't appear to be signed — which we (now? newly?) require, therefore merging is blocked.

Are you setup to sign your Git commits?

Copy link
Collaborator

@hminsky2002 hminsky2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nicer image! Approved

@kfogel
Copy link
Member Author

kfogel commented Sep 15, 2024

@kfogel Huh… I can see that you force-pushed a Solo Karl Fogel Commit™, but it doesn't appear to be signed — which we (now? newly?) require, therefore merging is blocked.

Are you setup to sign your Git commits?

@reefdog I asked this elsewhere, but since this is the original place I'll ask here too:

  1. Sign with GPG key or SSH key, or either is fine?
  2. Is the commit-signing requirement documented somewhere? (Hint: it's not documented in this repository...)

I'm happy to set this up; I'd just like to make sure I do it right.

@reefdog
Copy link
Collaborator

reefdog commented Sep 15, 2024

  1. Sign with GPG key or SSH key, or either is fine?

Either!

  1. Is the commit-signing requirement documented somewhere? (Hint: it's not documented in this repository...)

It's not… and it should be! I just added #68 to capture the issue.

In the interim, I think @hminsky2002 released the requirement, so we can temporarily trust you are you and merge this in.

@reefdog reefdog merged commit 3e67824 into main Sep 15, 2024
4 checks passed
@reefdog reefdog deleted the noimage-fancier branch September 15, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants