Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:move code to dependencies #571

Merged
merged 31 commits into from
Nov 2, 2024
Merged
Show file tree
Hide file tree
Changes from 29 commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
b994db3
fox:update requirements
JarbasAl Oct 18, 2024
f06f549
remove methods marked for deprecation
JarbasAl Oct 31, 2024
dc5143c
fixes
JarbasAl Oct 31, 2024
3deb78d
fix re-activation of skills that just deactivated themselves during t…
JarbasAl Oct 31, 2024
dffc516
account for session_id
JarbasAl Oct 31, 2024
7b05cea
remove deleted messages from tests
JarbasAl Oct 31, 2024
3ff749c
remove deleted messages from tests
JarbasAl Oct 31, 2024
ab045c5
update tests
JarbasAl Oct 31, 2024
6271636
fix converse
JarbasAl Oct 31, 2024
f941f4c
update tests
JarbasAl Oct 31, 2024
74e18d2
@coderabbitai suggestion
JarbasAl Oct 31, 2024
6e60aaa
revert change, we still need to update timestamps on active skills
JarbasAl Oct 31, 2024
fe3cbd7
fix get_response
JarbasAl Oct 31, 2024
e8b7764
fix:workshop2_compat
JarbasAl Oct 31, 2024
1099588
fix:workshop2_compat
JarbasAl Nov 1, 2024
b00ea99
fix:workshop2_compat
JarbasAl Nov 1, 2024
2f09cd9
fix:workshop2_compat
JarbasAl Nov 1, 2024
be84533
fix:workshop2_compat
JarbasAl Nov 1, 2024
9bdceaf
fix:workshop2_compat
JarbasAl Nov 1, 2024
3af9b7d
fix:workshop2_compat
JarbasAl Nov 1, 2024
4d86011
fix:workshop2_compat
JarbasAl Nov 1, 2024
58af9d6
fix:workshop2_compat
JarbasAl Nov 1, 2024
ec37d78
fix:workshop2_compat
JarbasAl Nov 1, 2024
d3b0c85
fix:workshop2_compat
JarbasAl Nov 1, 2024
2971403
deprecation logs
JarbasAl Nov 1, 2024
0bcea32
deprecation logs
JarbasAl Nov 2, 2024
d8359f2
tests moved to adapt repo
JarbasAl Nov 2, 2024
cc84d2f
fix deprecation warning version
JarbasAl Nov 2, 2024
e5a667a
fix adapt init
JarbasAl Nov 2, 2024
5a888ec
keep intent api unittest
JarbasAl Nov 2, 2024
d16a335
dont access deprecated stuff in tests
JarbasAl Nov 2, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions mycroft/skills/common_play_skill.py
Original file line number Diff line number Diff line change
Expand Up @@ -158,17 +158,14 @@ def __handle_play_start(self, message):
data = message.data.get("callback_data")

# Stop any currently playing audio
if self.audioservice and self.audioservice.is_playing:
self.audioservice.stop()
self.stop()

message.context["skill_id"] = self.skill_id
self.bus.emit(message.forward("mycroft.stop"))

# Save for CPS_play() later, e.g. if phrase includes modifiers like
# "... on the chromecast"
self.play_service_string = phrase

self.activate()

# Invoke derived class to provide playback data
self.CPS_start(phrase, data)

Expand Down
18 changes: 9 additions & 9 deletions mycroft/skills/intent_services/__init__.py
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
from ovos_core.intent_services import AdaptService,\
ConverseService, \
CommonQAService, \
FallbackService, \
PadaciosoService
from ovos_core.intent_services import IntentMatch
from mycroft.skills.intent_services.adapt_service import AdaptIntent, IntentBuilder, Intent
from ovos_core.intent_services.fallback_service import FallbackService
from ovos_core.intent_services.converse_service import ConverseService
from ovos_adapt.opm import AdaptPipeline as AdaptService
from padacioso.opm import PadaciosoPipeline as PadaciosoService
from ovos_commonqa.opm import CommonQAService
from ovos_plugin_manager.templates.pipeline import IntentMatch
from ovos_workshop.intents import Intent as AdaptIntent, IntentBuilder, Intent

try:
from ovos_core.intent_services.padatious_service import PadatiousService, PadatiousMatcher
from ovos_padatious.opm import PadatiousPipeline as PadatiousService, PadatiousMatcher
except ImportError:
from ovos_utils.log import LOG
LOG.warning("padatious not installed")
from ovos_core.intent_services.padacioso_service import PadaciosoService as PadatiousService
from padacioso.opm import PadaciosoPipeline as PadatiousService
5 changes: 3 additions & 2 deletions mycroft/skills/intent_services/adapt_service.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,11 @@
# limitations under the License.
#
"""An intent parsing service using the Adapt parser."""
from ovos_adapt.context import ContextManagerFrame
from ovos_adapt.engine import IntentDeterminationEngine
from ovos_workshop.intents import IntentBuilder, Intent
from ovos_adapt.opm import ContextManager, AdaptPipeline as AdaptService
from ovos_adapt.opm import AdaptPipeline as AdaptService
from ovos_bus_client.session import IntentContextManagerFrame as ContextManagerFrame, \
IntentContextManager as ContextManager


class AdaptIntent(IntentBuilder):
Expand Down
2 changes: 1 addition & 1 deletion mycroft/skills/intent_services/commonqa_service.py
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
from ovos_core.intent_services.commonqa_service import CommonQAService
from ovos_commonqa.opm import CommonQAService
EXTENSION_TIME = 10
2 changes: 1 addition & 1 deletion mycroft/skills/intent_services/padatious_service.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,5 @@
# limitations under the License.
#
"""Intent service wrapping padatious."""
from ovos_core.intent_services.padatious_service import PadatiousMatcher, PadatiousService, PadatiousIntent
from ovos_padatious.opm import PadatiousMatcher, PadatiousPipeline as PadatiousService, PadatiousIntent

Loading
Loading