Use dependencies from lib/@openzeppelin-contracts #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amxx
force-pushed
the
checks/eslint-solhint
branch
from
d4c3c93 to
3c1f788
Compare
|
I'm not able to replicate the prettier errors locally :/ |
arr00
reviewed
Dec 17, 2024
arr00
previously approved these changes
Dec 17, 2024
arr00
approved these changes
Dec 17, 2024
ernestognw
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR drops the dev dependency specified in
package.jsonin favor of these specified inlib/@openzeppelin-contracts/package.json. It helps maintain package parity between the repository.In particular this affect the linting packages and configurations (that are linked instead of copied).
Any dependency that only the community repo needs can be added to the local
package.json(for example@axelar-network/axelar-gmp-sdk-solidity), but any tools that in part of the main repo is automatically added here.This PR requires OpenZeppelin/openzeppelin-contracts#5368