update

OpenZeppelin · May 3, 2024 · ee47efc · ee47efc
1 parent 4512481
commit ee47efc
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/contracts/abstraction/mocks/AdvancedAccount.sol b/contracts/abstraction/mocks/AdvancedAccount.sol
@@ -86,6 +86,10 @@ contract AdvancedAccountECDSA is AdvancedAccount, AccountECDSA {
         PackedUserOperation calldata userOp,
         bytes32 userOpHash
     ) internal virtual override(Account, AccountMultisig) returns (uint256 validationData) {
+        // In this mock, calling super would work, but it may not depending on how the function is overriden by other
+        // modules. Using a more explicit override may bypass additional modules though.
+        //
+        // If possible, this should be improved.
         return AccountMultisig._validateSignature(userOp, userOpHash);
     }
 }
@@ -102,6 +106,10 @@ contract AdvancedAccountP256 is AdvancedAccount, AccountP256 {
         PackedUserOperation calldata userOp,
         bytes32 userOpHash
     ) internal virtual override(Account, AccountMultisig) returns (uint256 validationData) {
+        // In this mock, calling super would work, but it may not depending on how the function is overriden by other
+        // modules. Using a more explicit override may bypass additional modules though.
+        //
+        // If possible, this should be improved.
         return AccountMultisig._validateSignature(userOp, userOpHash);
     }
 }