-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump pragma to 0.8.22 for all contract that depend on ERC1967Utils #5273
Conversation
🦋 Changeset detectedLatest commit: 281c322 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
I think it is worth including a changeset/changelog entry for this. |
It was decided to include that in 5.2 |
I added an automated CI test that checks pragma consistency |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. It's worth noting that more complex pragma statements (such as pragma solidity >=0.8.20 <0.8.25;
) break the pragma checker script.
Yes that is known. We'll fix that when we need it I guess |
ERC1967Utils
emits events that are declared in theIERC1967.sol
interface. 0.8.22 fixes a bug regarding such events:See: https://soliditylang.org/blog/2023/10/25/solidity-0.8.22-release-announcement/