Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pragma to 0.8.22 for all contract that depend on ERC1967Utils #5273

Merged
merged 8 commits into from
Oct 22, 2024

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented Oct 21, 2024

ERC1967Utils emits events that are declared in the IERC1967.sol interface. 0.8.22 fixes a bug regarding such events:

NatSpec: Fix internal error when requesting userdoc or devdoc for a contract that emits an event defined in a foreign contract or interface.

See: https://soliditylang.org/blog/2023/10/25/solidity-0.8.22-release-announcement/

Copy link

changeset-bot bot commented Oct 21, 2024

🦋 Changeset detected

Latest commit: 281c322

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
openzeppelin-solidity Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Amxx Amxx requested a review from a team October 21, 2024 14:40
ericglau
ericglau previously approved these changes Oct 21, 2024
@ericglau
Copy link
Member

I think it is worth including a changeset/changelog entry for this.

@Amxx
Copy link
Collaborator Author

Amxx commented Oct 21, 2024

Is it worth publishing a patch (5.1.1) ?

It was decided to include that in 5.2

@Amxx Amxx added this to the 5.2 milestone Oct 22, 2024
@Amxx
Copy link
Collaborator Author

Amxx commented Oct 22, 2024

I added an automated CI test that checks pragma consistency

@Amxx Amxx requested review from ericglau and a team October 22, 2024 08:15
@Amxx Amxx requested review from arr00 and cairoeth October 22, 2024 13:22
Copy link
Contributor

@arr00 arr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. It's worth noting that more complex pragma statements (such as pragma solidity >=0.8.20 <0.8.25;) break the pragma checker script.

@Amxx
Copy link
Collaborator Author

Amxx commented Oct 22, 2024

It's worth noting that more complex pragma statements (such as pragma solidity >=0.8.20 <0.8.25;) break the pragma checker script.

Yes that is known. We'll fix that when we need it I guess

@Amxx Amxx merged commit c343ee3 into OpenZeppelin:master Oct 22, 2024
18 checks passed
@Amxx Amxx deleted the fix/erc1967utils-pragma branch October 22, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants