Add GovernorSequentialProposalId extension for sequential numbers on proposals #5290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Hadrien Croubois <[email protected]>
🦋 Changeset detectedLatest commit: b10f9be The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ernestognw
reviewed
Nov 1, 2024
contracts/governance/extensions/GovernorSequentialProposalId.sol
Outdated
Show resolved
Hide resolved
3 tasks
Amxx
reviewed
Nov 18, 2024
contracts/governance/extensions/GovernorSequentialProposalId.sol
Outdated
Show resolved
Hide resolved
Amxx
reviewed
Nov 18, 2024
contracts/governance/extensions/GovernorSequentialProposalId.sol
Outdated
Show resolved
Hide resolved
Amxx
reviewed
Nov 18, 2024
frangio
reviewed
Nov 18, 2024
contracts/governance/extensions/GovernorSequentialProposalId.sol
Outdated
Show resolved
Hide resolved
Amxx
reviewed
Nov 19, 2024
3 tasks
Amxx
reviewed
Dec 3, 2024
Amxx
reviewed
Dec 3, 2024
contracts/governance/extensions/GovernorSequentialProposalId.sol
Outdated
Show resolved
Hide resolved
Amxx
reviewed
Dec 3, 2024
Co-authored-by: Ernesto García <[email protected]>
Co-authored-by: Hadrien Croubois <[email protected]>
Amxx
reviewed
Dec 11, 2024
contracts/governance/extensions/GovernorSequentialProposalId.sol
Outdated
Show resolved
Hide resolved
ernestognw
reviewed
Dec 11, 2024
There was a problem hiding this comment.
Almost there, I agree with @Amxx that we should express the nextProposalId in terms of a lastProposalId to avoid initializing a variable unnecessarily during construction
ernestognw
reviewed
Dec 12, 2024
test/governance/extensions/GovernorSequentialProposalId.test.js
Outdated
Show resolved
Hide resolved
ernestognw
approved these changes
Dec 12, 2024
ernestognw
changed the title
Amxx
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative solution to #5280
PR Checklist
npx changeset add)