-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run linter on commit instead of push #5340
Conversation
|
@frangio I'm sure you'll have interresting feedback on this |
I have my opinions but I think it's up to you who will deal with this regularly. Technically this change seems fine. You could look into lint-staged if you wanted something that does the filtering out of the box. |
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/[email protected], pypi/[email protected], pypi/[email protected] |
I agree but I think it should be a balance. These two dependencies are fine but we're also extending the surface of maintaining and securing dependencies. We don't enjoy doing that much and is always low priority |
Doing that on push means we run lint when pushing tags, deleting remove banches, ... things that really don't need to run the linter.
Using husky and staged-lint to keep the project cleaner, (and stop reinventing the weel)