Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run linter on commit instead of push #5340

Merged
merged 7 commits into from
Dec 6, 2024

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented Dec 4, 2024

Doing that on push means we run lint when pushing tags, deleting remove banches, ... things that really don't need to run the linter.

Using husky and staged-lint to keep the project cleaner, (and stop reinventing the weel)

Copy link

changeset-bot bot commented Dec 4, 2024

⚠️ No Changeset found

Latest commit: f5bbf61

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

.githooks/pre-commit Outdated Show resolved Hide resolved
@Amxx
Copy link
Collaborator Author

Amxx commented Dec 4, 2024

@frangio I'm sure you'll have interresting feedback on this

@frangio
Copy link
Contributor

frangio commented Dec 4, 2024

I have my opinions but I think it's up to you who will deal with this regularly. Technically this change seems fine. You could look into lint-staged if you wanted something that does the filtering out of the box.

@Amxx Amxx requested a review from a team December 4, 2024 21:50
Copy link

socket-security bot commented Dec 4, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] None 0 4.04 kB typicode
npm/[email protected] Transitive: environment, filesystem, shell +46 1.98 MB okonet
npm/[email protected] None +5 240 kB doowb

🚮 Removed packages: npm/[email protected], pypi/[email protected], pypi/[email protected]

View full report↗︎

scripts/prepare.sh Outdated Show resolved Hide resolved
@ernestognw
Copy link
Member

Using husky and staged-lint to keep the project cleaner, (and stop reinventing the weel)

I agree but I think it should be a balance. These two dependencies are fine but we're also extending the surface of maintaining and securing dependencies. We don't enjoy doing that much and is always low priority

@Amxx Amxx merged commit 8829465 into OpenZeppelin:master Dec 6, 2024
17 checks passed
@Amxx Amxx deleted the git/lint-on-commit branch December 6, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants