Clarified Comments for Better Code Understanding Update Address.sol #5383
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR focuses on enhancing code clarity by adding more detailed comments to the functions
verifyCallResultFromTarget
and_revert
. The aim is to improve understanding for future developers, especially when debugging or reviewing the code.Clarified the comment in
verifyCallResultFromTarget
:// only check if target is a contract if the call was successful and there is no return data
Added a comment in the
_revert
function:// Use assembly to revert with returndata, which is the easiest way to propagate revert reasons
These changes aim to improve the readability of the code without altering any functionality.
npx changeset add
)