Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarified Comments for Better Code Understanding Update Address.sol #5383

Closed
wants to merge 1 commit into from

Conversation

0xwitty
Copy link
Contributor

@0xwitty 0xwitty commented Dec 18, 2024

Description

This PR focuses on enhancing code clarity by adding more detailed comments to the functions verifyCallResultFromTarget and _revert. The aim is to improve understanding for future developers, especially when debugging or reviewing the code.

  • Clarified the comment in verifyCallResultFromTarget:

    • Updated the comment to indicate that the contract check is performed only if the call is successful and there is no return data. This helps ensure that the logic around this check is more transparent.
    // only check if target is a contract if the call was successful and there is no return data
  • Added a comment in the _revert function:

    • Explained the use of assembly for propagating the revert reason. This change ensures that the process of handling revert reasons is clearer for anyone maintaining the code.
    // Use assembly to revert with returndata, which is the easiest way to propagate revert reasons

These changes aim to improve the readability of the code without altering any functionality.

  • Tests
  • Documentation
  • Changeset entry (run npx changeset add)

Copy link

changeset-bot bot commented Dec 18, 2024

⚠️ No Changeset found

Latest commit: d4e95f2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Amxx Amxx closed this Dec 19, 2024
@0xwitty 0xwitty deleted the patch-2 branch December 20, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants