Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix incorrect usage of import.meta.dirname in Node.js #5393

Closed
wants to merge 1 commit into from

Conversation

0xwitty
Copy link
Contributor

@0xwitty 0xwitty commented Dec 20, 2024

The current implementation references import.meta.dirname, which is not a valid property in Node.js. Instead, the correct approach is to use import.meta.url and convert it using path.

I’ve updated the code to properly handle this conversion, ensuring compatibility and correctness.

PR Checklist

  • Tests
  • Documentation
  • Changeset entry (run npx changeset add)

Copy link

changeset-bot bot commented Dec 20, 2024

⚠️ No Changeset found

Latest commit: 1f934aa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Amxx
Copy link
Collaborator

Amxx commented Dec 20, 2024

#5370

@Amxx Amxx closed this Dec 20, 2024
@0xwitty 0xwitty deleted the patch-2 branch December 20, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants