Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Error Handling and Improvements in File Deletion Process #5396

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ursulabauer
Copy link

I’ve made a few updates to improve the stability and clarity of the file deletion script. The most significant change is the addition of error handling using try...catch, which will prevent the script from failing unexpectedly when deleting files. Additionally, I’ve updated the fs.readFileSync() method by specifying the utf8 encoding to ensure the file is read as text, avoiding potential encoding issues.

The message logged when deleting files has also been updated to specifically reference "build artifacts" rather than just "files," which provides clearer context.

These improvements should help avoid errors during the file removal process and enhance the script's overall reliability.

PR Checklist

  • Tests
  • Documentation
  • Changeset entry (run npx changeset add)

Copy link

changeset-bot bot commented Dec 21, 2024

⚠️ No Changeset found

Latest commit: d637497

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant